build: dedupe targets in api golden script#32669
Merged
crisbeto merged 1 commit intoangular:mainfrom Jan 20, 2026
Merged
Conversation
In the past we had one API golden target per component, but now the target is per package. This means that if we run something like `approve-goldens material/button material/dialog material/datepicker`, we'll run the same command three times. These changes dedupe the set of targets.
angular-robot
Bot
added
the
area: build & ci
Member
Author
crisbeto
added a commit
that referenced
this pull request
Jan 20, 2026
In the past we had one API golden target per component, but now the target is per package. This means that if we run something like `approve-goldens material/button material/dialog material/datepicker`, we'll run the same command three times. These changes dedupe the set of targets. (cherry picked from commit 1f8b4b5)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past we had one API golden target per component, but now the target is per package. This means that if we run something like
approve-goldens material/button material/dialog material/datepicker, we'll run the same command three times.These changes dedupe the set of targets.